Fix the race condition in transaction queue start() call

Fitbit / bitgatt

The FitbitGatt API is designed to provide a strong state machine around all Android gatt operations with the aim of making Android BLE development across Android vendors as straightforward and side-effect free as possible.

Mozilla Public License 2.0

57 stars 17 forks source link

Fix the race condition in transaction queue start() call #29

Closed ShawnW858 closed 4 years ago

ShawnW858 commented 4 years ago

Fixes #

description

Resolve the race condition on start() call This is the side effect of this PR. Before this PR#26, we used to call start() before queueTransaction().

changes

change queueTransaction() as synchronized call to prevent from triggering multiple TransactionQueueController.start() calls.
Also a minor tweak for onConnectionStateChange

how tested

Added new android test case and verified we don't invoke start queue multiple times.

droolingsheep commented 4 years ago

Looks like my approval isn't enough. I think we'll need @dragosdi