Fitbit / developer-bridge

TypeScript implementations of the Fitbit Developer Bridge
https://dev.fitbit.com
20 stars 17 forks source link

--local option for 'connect' to connect through Local Relay #176

Closed rafasofizada closed 2 years ago

Hexxeh commented 3 years ago

Note that the commands previously contain very little actual logic, instead calling out to a different file. Typically the commands themselves contain only argument validation/sanity checks, and call out to a file under models for their actual business logic.

Doing this will make your life simpler when you write tests to go with this PR.

coveralls commented 2 years ago

Coverage Status

Coverage increased (+0.09%) to 94.132% when pulling 62f582dcf7fa7a76ba7082ae1ccdece811690c70 on rafasofizada:local-relay into 9dcf9f72cf454fc0240d75a7b1b6ae1d3dc94fb2 on Fitbit:master.

Hexxeh commented 2 years ago

Looks like CI is failing still with a lint error this time. The commit hook should be notifying you of this when you commit: can you confirm it's firing when you commit?

Hexxeh commented 2 years ago

Created feature/local-relay as a feature branch to merge this to.