search

Fitbit / fitbit-sdk-toolchain

Toolchain for building Fitbit apps
https://dev.fitbit.com
BSD 3-Clause "New" or "Revised" License
54 stars 8 forks source link

Incompatibility with Node 17 #279

Open PanisSupraOmnia opened 2 years ago

PanisSupraOmnia commented 2 years ago

Hi, currently trying to run npx fitbit-build on Node 17 fails with an error because of the following: https://github.com/Fitbit/fitbit-sdk-toolchain/blob/58ea8a7d4f76420b2291589017869e801f9b829a/src/plugins/typescript/tslib.const.ts#L5-L6 The issue seems to be with the exports field in tslib's package.json. It doesn't have package.json as a specified export, so you end up with an 'ERR_PACKAGE_PATH_NOT_EXPORTED' error code. Let me know if there's any other useful info I can provide; I'm new to Node so I don't think I can PR a fix unless pointed in the right direction.

Hexxeh commented 2 years ago

It seems this is a breaking change made in Node 17. We haven't had a new toolchain release since Node 17 was released, so I'd suggest using Node 16 (or 14, both LTS) in the meantime.

PanisSupraOmnia commented 2 years ago

Ok, thanks! When I originally ran into this incompatibility I set up a Docker image for builds, so I'll stick with that.