search

FitnessKit / FitDataProtocol

Swift Implementation the Garmin Flexible and Interoperable Data Transfer Protocol.
https://fitnesskit.github.io/FitDataProtocol/
MIT License
51 stars 15 forks source link

func encodeDefinitionMessage using incorrect global message number #26

Closed antokne closed 1 year ago

antokne commented 1 year ago

Hi, Just noticed a few examples where the global message number is using the wrong class.

e.g. https://github.com/FitnessKit/FitDataProtocol/blob/7d62bfd0027decb50f2e95c801f3ea30a011fb61/Sources/FitDataProtocol/Messages/DeviceSettingsMessage.swift#LL280C54-L280C54

Thinking you might be able to change this to e.g. Self.globalMessageNumber() now?

khoogheem commented 1 year ago

2.1.6 should fix for spm