search

Fitoussi / geo-my-wp

Advanced mapping and geolocation plugin for Wordpress
https://geomywp.com
36 stars 22 forks source link

Fix JS error 'Uncaught SyntaxError: Unexpected identifier'. #62

Closed jhume closed 5 years ago

jhume commented 6 years ago

When I upgraded from version 2 to 3.1 my maps would not load at all due to a JS error in Chrome "Uncaught SyntaxError: Unexpected identifier". To resolve I escaped the double quotes.

It would be great to have this fix added to the module to avoid having to re-add it each time I upgrade.

Cheers,

John

Fitoussi commented 5 years ago

HI, I am not sure how the issue you described is related to the solution you suggested. This solution will break the attribution link. I was also unable to duplicate this issue nor anyone else has reported it.

Please try again after the next release of the plugin and see if the issue returns. If it is, I am happy to have a look at it.

You could also use the filter 'gmw_map_element' in the same class-gmw-maps-api.php file to modify the map options and either edit or remove the link. That's instead of modifying the file.