search

Fitpassu / react-native-stripe-payments

Lightweight, easy to integrate and use React native library for Stripe payments (using Payment Intents) compliant with SCA (strong customer authentication)
MIT License
98 stars 31 forks source link

URGENT - Android Build Fails When Targeting API LEVEL 31 & Above #45

Open jogbuwa opened 1 year ago

jogbuwa commented 1 year ago

Hey @viktorasl ,

Commendations for the great work you have done with the React Native Stripe Payments implementation. I've been a user of this library on our mobile app for about a year now and everything seemed to work fine until very recently;

We have just made some very important UI and feature updates to our mobile app, and following the very recent deadline enforcement by Google to ensure that app bundles uploaded to the Play Store must target the API Level 31 & Above, we have also targeted the said API level.

However, since targeting API Level 31 & above, the android app build fails at every attempt with the error reference to the React Native Stripe Payments module. But when we reverse back to target API Level 30 (the previous API level at development time), the build becomes successful.

Is it likely that you can look into this issue to find a possible fix as we are currently stuck on options to get important updates to the Store for our users to access.

Thanks

viktorasl commented 1 year ago

Hey @jogbuwa, sorry for this inconvenience. I'll take a look!

jogbuwa commented 1 year ago

Hey @jogbuwa, sorry for this inconvenience. I'll take a look!

Thank you @viktorasl ! Looking forward to it.

jogbuwa commented 1 year ago

Hey @viktorasl ,

Commendations for the great work you have done with the React Native Stripe Payments implementation. I've been a user of this library on our mobile app for about a year now and everything seemed to work fine until very recently;

We have just made some very important UI and feature updates to our mobile app, and following the very recent deadline enforcement by Google to ensure that app bundles uploaded to the Play Store must target the API Level 31 & Above, we have also targeted the said API level.

However, since targeting API Level 31 & above, the android app build fails at every attempt with the error reference to the React Native Stripe Payments module. But when we reverse back to target API Level 30 (the previous API level at development time), the build becomes successful.

Is it likely that you can look into this issue to find a possible fix as we are currently stuck on options to get important updates to the Store for our users to access.

Thanks

@viktorasl Just to provide extra context here:

SCREENSHOT 1: IMG-20230222-WA0001_

SCREENSHOT 2: IMG-20230222-WA0002_

viktorasl commented 1 year ago

I doubt I'll come up with a quick fix, because it looks like the error is related to Stripe library (com.stripe.android.payments.StripeBrowserLauncherActivity). I'll have to update the stripe library version which causes a lot of changes required.

Stripe have released their official RN library https://github.com/stripe/stripe-react-native. Probably it's a high time to use it.

jogbuwa commented 1 year ago

I doubt I'll come up with a quick fix, because it looks like the error is related to Stripe library (com.stripe.android.payments.StripeBrowserLauncherActivity). I'll have to update the stripe library version which causes a lot of changes required.

Stripe have released their official RN library https://github.com/stripe/stripe-react-native. Probably it's a high time to use it.

Okay, thanks for your response. Will keep an eye on this issue to see what fix you can come up with. In the meantime, I'll start looking at the Stripe official RN library.

jogbuwa commented 1 year ago

Hey @viktorasl Any chance you've had a breakthrough with this issue?

viktorasl commented 1 year ago

Hey @viktorasl Any chance you've had a breakthrough with this issue?

Unfortunately not yet

viktorasl commented 1 year ago

Hey @jogbuwa, if you're still blocked (geez, hopefully you're not) I've released 1.1.0 lib version with Stripe 20.x iOS and Android support. Give it a try, although as I've said I recommend migrating to official Stripe RN library.

jogbuwa commented 1 year ago

Hey @viktorasl Thank you for getting back to me. LOL...we aren't still blocked anymore (although we were for a considerable time) as we have migrated to the official Stripe RN library.

However, I think I can still give your update a try on a different project that's on a sandbox server.

Thank you so much for your support.