Fitpassu / react-native-stripe-payments

Lightweight, easy to integrate and use React native library for Stripe payments (using Payment Intents) compliant with SCA (strong customer authentication)
MIT License
98 stars 30 forks source link

Final PR from aspect-apps #8

Open 0xamogh opened 4 years ago

0xamogh commented 4 years ago
0xamogh commented 4 years ago

@lukebrandonfarrell @ChesterSim @viktorasl

viktorasl commented 4 years ago

Looks solid! Code reviewing it now!

lukebrandonfarrell commented 4 years ago

Hey @viktorasl, thanks for the in-depth review :) I think @amogh-jrules or @ChesterSim will be able to address some of these issues.

I believe we did run into issues with Multidex

0xamogh commented 4 years ago

Apologies for the late response, the gitignore changes have been made, we were having some trouble installing it locally

rawatnaresh commented 3 years ago

how can I use this branch in my project? I did yarn add https://github.com/aspect-apps/react-native-stripe-payments but when I ran the project I got an error saying: Error: There was an unexpected error -- try again in a few seconds. switching to the master branch works as expected.

I really need some of the features from this branch, I even tried manually creating the native modules and using it like:

NativeModules.StripePayments.init('publishable_key')
...
NativeModules.StripePayments.confirmSetup('client_secret_from_backend', cardParams)

but got the same error 😕 . Cleaned build folder, reinstalled Pods, restarted the metro server and ran again, but same error. I must be missing something but not sure what.