Hey @longlostbro , I made some sweeping changes to your pull request and I wanted to go over it with you. If you want to test this out, just git fetch and then git checkout -b David-suggestion and it should get my changes onto your local machine as a new branch called David-suggestion. This changes the actual behavior of some of the things your code does (so its not truly the same), but I feel like that this code is a little bit more maintainable without as many gotcha moments. (For instance, in yours, clicking on a timer when the settings window is expanded colors it, but then closing the settings transitions out the color?) These are just some of the things I suggested looking into in google hangouts but I wasn't sure if you knew what I meant.
Hey @longlostbro , I made some sweeping changes to your pull request and I wanted to go over it with you. If you want to test this out, just
git fetchand thengit checkout -b David-suggestionand it should get my changes onto your local machine as a new branch called David-suggestion. This changes the actual behavior of some of the things your code does (so its not truly the same), but I feel like that this code is a little bit more maintainable without as many gotcha moments. (For instance, in yours, clicking on a timer when the settings window is expanded colors it, but then closing the settings transitions out the color?) These are just some of the things I suggested looking into in google hangouts but I wasn't sure if you knew what I meant.