search

Fivefold / linkding-injector

Injects search results from the linkding bookmark service into search pages like google and duckduckgo
MIT License
216 stars 8 forks source link

Added support for the kagi search engine. #21

Closed danbush closed 1 year ago

danbush commented 1 year ago

Just a small update to support the privacy-focused search engine, Kagi!

Fivefold commented 1 year ago

Hey @danbush, thanks a lot for taken the time to get to know the codebase and make the necessary changes! I really appreciate it. I checked your PR out a bit and it looks good so far but would need a few changes.

The major problem though is that kagi is behind a paywall and while there's a trial tier it's only 100 searches for one time. This is enough to test this PR but means I can't properly test or support this in the future if something breaks. The searches will eventually run out.

Are you willing to become a proper maintainer (for the kagi side of things)?

danbush commented 1 year ago

Hey! I've never been a maintainer for something beyond my personal projects (or at work), so I'm not 100% sure what I'd be signing up for, but if it would just mean updating it as needed, sure I'm willing! I made these changes mostly just for myself, so I'd be fixing it as bugs come up either way haha

Fivefold commented 1 year ago

Hey! I've never been a maintainer for something beyond my personal projects (or at work), so I'm not 100% sure what I'd be signing up for, but if it would just mean updating it as needed, sure I'm willing! I made these changes mostly just for myself, so I'd be fixing it as bugs come up either way haha

Yes, it's just updating when something breaks for Kagi and/or testing when I change something in the injection code that might affect Kagi.

Fivefold commented 1 year ago

Thanks for the additional commits. There were still a few small issues, I just took them on myself. I also made two comments in the review conversations above.

Automatic theme detection should work now, maybe you can give it a spin on your end just to make sure.

Unfortunately there's still a little bit of broken styling: when you explicitly set dark or light style in the extension settings and then switch between explicit dark or light theme in kagi the font color of bookmark descriptions change. There should be no changes in colours when an explicit theme is set for the injection box.

It's still usable and I couldn't figure out a way to make it work today, so I will leave it as is for now. If you are feeling motivated, you can try your hand. Otherwise I will merge this as is since I don't think anyone actually uses the explicit styles anyway.

danbush commented 1 year ago

Unfortunately there's still a little bit of broken styling: when you explicitly set dark or light style in the extension settings and then switch between explicit dark or light theme in kagi the font color of bookmark descriptions change. There should be no changes in colours when an explicit theme is set for the injection box.

Yeah I noticed this. I think its at least related to the fact that kagi has some styles specifically attached to OS-level dark mode that ignores the website-level decision. Kinda weird. IMO good enough to push as it, and if anyone other than me ends up using this and requests a fix I can look back at trying to solve it 😄

Fivefold commented 1 year ago

That's reasonable! Happy to merge, thank you again, will go live in the next release