search

Fivefold / linkding-injector

Injects search results from the linkding bookmark service into search pages like google and duckduckgo
MIT License
194 stars 7 forks source link

Duckduckgo injection broken #25

Closed Fivefold closed 6 months ago

Fivefold commented 7 months ago 
          @Fivefold Sorry to necro this issue but i noticed that in version 1.3.4 with duckduckgo the injector is not working.

imagem

linkding injector: no message and no search results searchInjection.js:150:12 <anónimo> searchInjection.js:150

I did try with google and it works as expected.

Originally posted by @GulyFMG in https://github.com/Fivefold/linkding-injector/issues/18#issuecomment-1912563973

Fivefold commented 7 months ago

@GulyFMG unfortunately I can't replicate your issue. Are you using firefox or chrome? What settings are you using in the extension?

GulyFMG commented 7 months ago

I did try again at hme and it worked fine... When i was doing my initial testing i was inside a very restricted network. Monday i will try again to make sure. But at home the extension is working fine.

GulyFMG commented 7 months ago

I found out what the problem is. With the corporate VPN on the results are not shown. If i turn off the VPN the Extension works as intended. I think this can be closed.

Fivefold commented 7 months ago

Thank you for verifying!

I was unable to replicate your behaviour with a linkding instance that suddenly becomes unreachable. In that case it just silently fails, which isn't ideal but different behaviour to yours. Maybe your corporate network lets it connect but removes the content of the response, that's the only way I can think of right now that would give you the no message and no search results error message in the console.

If you think there's a chance this could work through your corporate VPN (i.e. the problem actually lies in the extension implementation and not through some blocking action of your company's firewall) we can investigate further but you would need to do some work debugging the connection and possibly the extension.

If you are fine with it only working outside of your corporate network please close the issue. It's an edge case after all and I can't replicate the issue.

Fivefold commented 6 months ago

Closing due to inactivity