search

FixMyBerlin / rsv-dossier

FixMyCity's information website about planning and building cycle highways in Germany
https://radschnellverbindungen.info/
MIT License
4 stars 0 forks source link

Update Infobox with Mail Link #103

Closed rush42 closed 1 year ago

rush42 commented 1 year ago

This PR adds the update info button as described in https://github.com/FixMyBerlin/private-issues/issues/45 .

netlify[bot] commented 1 year ago

Deploy Preview for rsv-dossier ready!

Name Link
Latest commit 8dfe200046ca5413c4b76936ef43fa7a5c28f73e
Latest deploy log https://app.netlify.com/sites/rsv-dossier/deploys/6475eb196a73cb000878cef3
Deploy Preview https://deploy-preview-103--rsv-dossier.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rush42 commented 1 year ago

Update: I removed the conditional from the stakeholder info on the steckbrief page and aligned the info icon with that line to follow the design. Because the JSON schema ensures that we have at least one stakeholer and names are mandatory on stakeholders this was no longer necessary , FYI @JohannaPeanut . The MailTo link is also added and the subject is "Anliegen zum {RSV-Name}". In the design the mail link is underlined by default which contradicts with our existing style that is that links get underlined only when the cursor hovers.

rush42 commented 1 year ago

Update 2: I also added a click event and a key press handler to close the dialog when the outside area or any key is pressed therefore I needed to set aria-hidden=true (linter required this). I don't know if this has any unwanted side effects. Do you know more @tordans ?

I also colored the mail to link so it is also visible when not hovered over....

rush42 commented 1 year ago

Note: the scroll on the right side of the map gets reset when the info icon is clicked (due to the component rerendering).