search

FixTweet / FxTwitter

Fix broken Twitter/X embeds! Use multiple images, videos, polls, translations and more on Discord, Telegram and others
https://fxtwitter.com
MIT License
2.69k stars 80 forks source link

Translated tweet embed does not show the tweet in it's original language #421

Closed RisingFog closed 1 year ago

RisingFog commented 1 year ago

According to the readme for FixTweet, tweets show translated with the original tweet untranslated below:

image

As of now, the embed looks like the following:

image

Is this something that was intentionally changed, and if not, is it possible to add functionality to show the original language within the embed?

dangeredwolf commented 1 year ago

Oops, yeah, this is a case of the documentation being outdated. We changed this behavior for embeds as it gets unwieldy very quickly with Tweets that have more than a couple sentences. In Telegram, we actually show both in Instant View as it pops out to another screen and has a lot more room, but the embed preview for it is the same like Discord. We also simply make the assumption that if you're going to go out of your way to tell FixTweet to translate the tweet that most of the time, people just want that preview translated. I suppose if there's demand we could try to show both in tweets that are short enough, but I'm not sure how many people would actually want that.

RisingFog commented 1 year ago

That's fair enough, I just wanted to make sure if it was a bug or not. Showing both is definitely a niche use case, but could be useful to double check if the translated message is accurate to the original message. Then again, one could also just click on the link to go to the actual tweet for that I guess.

It's ultimately your call but I'll leave the issue open just in case.

dangeredwolf commented 1 year ago

I should probably update the documentation <.<