search

FixTweet / FxTwitter

Fix broken Twitter/X embeds! Use multiple images, videos, polls, translations and more on Discord, Telegram and others
https://fxtwitter.com
MIT License
2.62k stars 77 forks source link

Video doesn’t play on IOS - Discord #859

Closed Abdousoussi closed 2 months ago

Abdousoussi commented 4 months ago

Exactly what the title says. Videos no longer play on discord for some reason. I tap them, but it just full screens the frame that the embed was in and keeps buffering.

Im using the latest discord and I’m using an IPhone 13 Pro

umbra3275 commented 3 months ago

I also am experiencing this. It seems to be intermittent though, as some videos play and some others don't. Downloading the videos, some of them appear to be fragmented mp4 files? I'm not sure if that's the reason though.

umbra3275 commented 3 months ago

https://fxtwitter.com/sleepychux/status/1806053249654423899 here's a link that doesn't play on IOS for me

Delphox commented 2 months ago

vxtwitter fixed this a while ago, on their code comment it seems like iOS doesn't like when twitter video urls end in .mp4, so their solution was proxying the video urls to get rid of it. This also seems to have fixed the video seeking issue on the desktop app (https://github.com/FixTweet/FxTwitter/issues/872). Although I have never seen this .mp4 issue on non-twitter videos so idk if they're non-compliant in some way that breaks Discord's media proxy or something.

dangeredwolf commented 2 months ago

That’s really interesting, I’ll have to test this out later today and see if that’s all it takes. Thanks for the tip!

dangeredwolf commented 2 months ago

Thanks for the tip @Delphox as I haven't noticed that workaround was so simple <.<

Delphox commented 2 months ago

Thanks for implementing it! One last thing, you should also do the same on GIFs. They're susceptible to the same issue (just tested seeking on an unbuffed gif and it has the same issue so I assume its also broken on iOS) but since they're already proxied it should be just a matter of stripping the extension.

dangeredwolf commented 2 months ago

Ah yes, I made a subtle change to fix this https://github.com/FixTweet/FxTwitter/commit/966ffd0eceb667f2c2775b66fd64e616a058844b