FixedEffects / FixedEffectModels.jl

Fast Estimation of Linear Models with IV and High Dimensional Categorical Variables
Other
227 stars 46 forks source link

Add fe(s::Symbol) for programmatic formula construction #116

Closed junyuan-chen closed 4 years ago

junyuan-chen commented 4 years ago

When constructing a formula programmatically, calling Term inside fe is verbose. It seems that nothing is relying on having an AbstractTerm to be called by fe. So, I suggest simplifying the syntax by directly passing the Symbol s to fe.

It is also easier to add multiple fixed effects from an array like this: reduce(+, fe.([:State, :Year])).

matthieugomez commented 4 years ago

Thanks!