FixedEffects / FixedEffectModels.jl

Fast Estimation of Linear Models with IV and High Dimensional Categorical Variables
Other
225 stars 46 forks source link

display both types of dof #231

Closed matthieugomez closed 1 year ago

matthieugomez commented 1 year ago

also: only need to substract 1 from number of cols of X if has_intercept

solves https://github.com/FixedEffects/FixedEffectModels.jl/issues/230

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (ba6228e) 95.54% compared to head (2a2b5f1) 95.57%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #231 +/- ## ========================================== + Coverage 95.54% 95.57% +0.02% ========================================== Files 7 8 +1 Lines 606 610 +4 ========================================== + Hits 579 583 +4 Misses 27 27 ``` | [Impacted Files](https://app.codecov.io/gh/FixedEffects/FixedEffectModels.jl/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None) | Coverage Δ | | |---|---|---| | [src/FixedEffectModel.jl](https://app.codecov.io/gh/FixedEffects/FixedEffectModels.jl/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL0ZpeGVkRWZmZWN0TW9kZWwuamw=) | `90.24% <ø> (ø)` | | | [src/fit.jl](https://app.codecov.io/gh/FixedEffects/FixedEffectModels.jl/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None#diff-c3JjL2ZpdC5qbA==) | `96.34% <100.00%> (-0.02%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/FixedEffects/FixedEffectModels.jl/pull/231/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.