Closed nilshg closed 10 months ago
Attention: 1 lines
in your changes are missing coverage. Please review.
Comparison is base (
4c5e187
) 96.35% compared to head (27bd9e8
) 96.21%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks!
The current definition of
Combination
introduces an implicit zero-arg method which means the type parameter inCombination(A::Union{AbstractMatrix{T}, AbstractVector{T}}) where T
becomes unbounded. This leads to additional work for the compiler which can lead to latency issues.Explicitly adding a zero-arg method
Combination()
which errors solves this - as far as I can see there's no sensible way in which a zero-arg version could be used, it errors currently anyway and throwing an explicity error is a UX improvement (if marginal as this error would probably encounter somewhere in the stack without the user callingCombination()
themselves).Happily this is the only Aqua test failure for FixedEffectModels, so we could think about adding Aqua to CI and displaying an Aqua badge, which more and more users seem to look for as a basic quality indicator.