search

FixedEffects / Vcov.jl

Variance Covariance Matrices for developers
Other
9 stars 4 forks source link

Improve completecases for ClusterCovariance #7

Closed junyuan-chen closed 3 years ago

junyuan-chen commented 3 years ago

I have made some changes to completecases that echos the recent changes made with DataFrames.completecases. Now, finding missing values will only happen when the element type of the column contains Missing.

codecov-commenter commented 3 years ago

Codecov Report

Merging #7 (9733b3e) into master (a251146) will increase coverage by 8.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master       #7      +/-   ##
==========================================
+ Coverage   32.62%   40.62%   +8.00%     
==========================================
  Files           7        7              
  Lines         187      192       +5     
==========================================
+ Hits           61       78      +17     
+ Misses        126      114      -12
Impacted Files Coverage Δ
src/covarianceestimators/vcovcluster.jl 58.62% <100.00%> (+12.67%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a251146...9733b3e. Read the comment docs.

matthieugomez commented 3 years ago

Thanks!