FizzleDorf / ComfyUI_FizzNodes

Custom Nodes for Comfyui
MIT License
370 stars 56 forks source link

please add simplejson to requirements.txt #10

Closed vincenzoml closed 11 months ago

vincenzoml commented 11 months ago

As in subject :)

FizzleDorf commented 11 months ago

this has been done 4 months ago, you can check it out here. If there is an issue related to installing simplejson through the requirements.txt, walk me through the process so I can try to replicate it otherwise close this issue.

vincenzoml commented 11 months ago

Oh, sorry, I assumed it was not there because I did pip install -r requirements.txt and afterwards, the simplejson package was missing. You can check this easily e.g. using a docker machine. Maybe because there's a missing newline at the end of requirements.txt?

FizzleDorf commented 11 months ago

Maybe because there's a missing newline at the end of requirements.txt?

this was it. Thanks for the heads up. I've made an update (it doesn't actually show the newline in git but it's there. I pulled and checked)

FizzleDorf commented 11 months ago

I simply removed simplejson and just used the standard json module.

vincenzoml commented 11 months ago

Great!