search

FizzleDorf / ComfyUI_FizzNodes

Custom Nodes for Comfyui
MIT License
396 stars 60 forks source link

Batch Prompt Schedule not moving to the next prompt #22

Closed sixex44 closed 1 year ago

sixex44 commented 1 year ago

Hello, BatchPromptSchedule in Comfy UI is only running the first prompt, I had it working previously and now when running a json that did go through the scheduled prompts it will only use the first.

FizzleDorf commented 1 year ago

Can you verify you are on the latest version? This was a problem a few days ago when I was trying to increase the token limit for batches. Latest should not have this problem still.

sixex44 commented 1 year ago

yes, I deleted whatever version I was on and installed the current and still getting the issue. Everything was working fine for me until a few days ago. Thanks

On Sat, Oct 28, 2023 at 9:59 AM FizzleDorf @.***> wrote:

Can you verify you are on the latest version? This was a problem a few days ago when I was trying to increase the token limit for batches. Latest should not have this problem still.

— Reply to this email directly, view it on GitHub https://github.com/FizzleDorf/ComfyUI_FizzNodes/issues/22#issuecomment-1783856982, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3O2JEBZW4CX7KI6LEJ7JFDYBUTW3AVCNFSM6AAAAAA6TMGBGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTHA2TMOJYGI . You are receiving this because you authored the thread.Message ID: @.***>

FizzleDorf commented 1 year ago

I can't seem to replicate the issue. Can you send me your workflow or something similar for testing?

sixex44 commented 1 year ago

here's my workflow, thank you.

On Sun, Oct 29, 2023 at 12:08 AM FizzleDorf @.***> wrote:

I can't seem to replicate the issue. Can you send me your workflow or something similar for testing?

— Reply to this email directly, view it on GitHub https://github.com/FizzleDorf/ComfyUI_FizzNodes/issues/22#issuecomment-1784008924, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3O2JEDOPDYAVZLCH3KGKKTYBXXFPAVCNFSM6AAAAAA6TMGBGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGAYDQOJSGQ . You are receiving this because you authored the thread.Message ID: @.***>

sixex44 commented 1 year ago

downgrading my Comfy UI and Animate Diff has fixed the issue. Not sure why the upgrades aren't working properly but I can use the downgraded versions for now. Thanks

On Sun, Oct 29, 2023 at 11:56 AM chris may @.***> wrote:

here's my workflow, thank you.

On Sun, Oct 29, 2023 at 12:08 AM FizzleDorf @.***> wrote:

I can't seem to replicate the issue. Can you send me your workflow or something similar for testing?

— Reply to this email directly, view it on GitHub https://github.com/FizzleDorf/ComfyUI_FizzNodes/issues/22#issuecomment-1784008924, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3O2JEDOPDYAVZLCH3KGKKTYBXXFPAVCNFSM6AAAAAA6TMGBGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGAYDQOJSGQ . You are receiving this because you authored the thread.Message ID: @.***>

Boldor83 commented 1 year ago

i got the problem too, tested old workflows and simple color transition at half and it stays at first color. i tried reinstall of the node in manager but it didn't help

Edit: I just tried a fresh comfyui install with newest release and installed just animatediff and fizznodes and still get the error

Boldor83 commented 1 year ago

might be new issue, but after the latest update it no longer ignores the next prompt but the scheduling doesn't work right either. now everything in the box gets merged together. For example

"0": "a young woman in spring", "20": "a young woman in autumn", "40": "a young woman in winter"

has a mix of the 3 seasons right from the beginning, same with red cat and blue dog creates a mix of both. AnimateDiff_00202_ AnimateDiff_00201_

i attached two pngs with workflow. it worked with this kind of workflow before.

I used txt2vid with scheduler workflow from this guide https://civitai.com/articles/2379/guide-comfyui-animatediff-guideworkflows-including-prompt-scheduling-an-inner-reflections-guide just reduced a bit to test the problem

Boldor83 commented 1 year ago

replacing BatchPromptSchedule with BatchPromptSchedule(LatentInput) the transition works, but the behavior seems a little different. when starting at 20 with 40 latent input the transition starts very fast, putting start of the prompt at 40 its more even.

Boldor83 commented 1 year ago

Alright the culprit was max frames not being same as latent batch. this wasn't breaking the workflow to behave wrong before, if its same it works again.