search

FjolleJagt / kbhff_selenium_tests

2 stars 1 forks source link

Browser fixture #4

Closed cleborys closed 5 years ago

cleborys commented 5 years ago

driver_list fixtures enables tests to easily work with several browsers by wrapping everything in for driver in driver_list. This is not ideal, as a failing test in any browser will cause the test for all browsers to fail, see issue #1.

FjolleJagt commented 5 years ago

You're currently merging this into master; could you merge this into create_dummy_user instead, so I can see a diff with that? (Or merge the other pull request into master and leave this as-is.)

cleborys commented 5 years ago

Creating the dummy user seems broken when running from docker, I am not sure how to connect to the database. Thus all "positive" tests assuming that there is a valid user are failing when running in docker.

FjolleJagt commented 5 years ago

Seems fine to me; do you still have the problems with creating the dummy user, or is that now fixed by exposing the db? I would prefer if we only had passing tests on master.

cleborys commented 5 years ago

Seems fine to me; do you still have the problems with creating the dummy user, or is that now fixed by exposing the db? I would prefer if we only had passing tests on master.

That was the problem, yes. This now works, as long as parentnode_docker with the version that exposes the database on the appropriate port is used.

cleborys commented 5 years ago

(Just verified that everything is passing in my setup)