Event (Mystery Gift) missing in database

[CornFlakes999]

Hi I looked all over the place in the "events" but there seems to be that these two Wondercards are missing: Own Tempo Rockruff with "Thunder Fang" for Ultra Moon (UM) [Only the one with "Fire Fang" for UltraSun is in the list) Paris Vivillion for X/Y [Only a similar one is in the list from Summer 2014] Here are the Wondercards on Project Pokemon: Rockruff (select the Thunder Fang one) >> https://projectpokemon.org/home/files/file/2385-own-tempo-rockruff-dusk-lycanroc/ Paris Vivillon >> https://projectpokemon.org/home/files/file/943-0511-xy-paris-pkmn-center-6014-vivillon-pokeball-forme-fre-m/

I hope its possible to add them to the database and it's not too much to ask. In case it is difficult to do, I'm also happy to send a $5 compensation for the work with Paypal (:

Thanks!!

[GriffinG1]

PKSM pulls mystery gift data from this repo. Any issues with missing mystery gifts should be brought there.

[CornFlakes999]

Thanks for the fast reply!!! I just check on that repo. According to this, it should have both, but in PKSM I only see one :( By chance am I just stupid here and missing something I should enable first? I attached the screen for the repo saying they have both Rockruff for US and UM, but also a screen of the Event Database shown in PKSM when I have Ultra Moon inserted. It only has the one and selecting it says "Fire Fang" and Game US

[piepie62]

That's... disgusting. Game Freak, why the hell did you clone your Wonder Cards?

[piepie62]

The way that we mash the mystery gifts into a couple files is completely automated, and doesn't take receiving game into account as part of the metadata. To the tool we use, those two cards are identical.

[piepie62]

As for the Vivillon, is there something that's showing up that's similar in the same way?

[CornFlakes999]

I'm not a coder, so the following comment is either complete nonsense to you or a helpful hint. it seems on the Gen 6 (X/Y/OR/AS) PKSM is able to show multiple entries, even if the Wondercard is identical. Example here the "Arceus" with 0081. It shows all variants. (Shiny with Silk Scarf and all the Non Shiny with a random plate. Depending on which one I would select for the Arceus, I get either "Shiny, holding Silk Scarf" or "Regular, Holding xxx Plate" (16 WC with 0081 ID in Total) I think I seen some other wondercards with the same ID showing side by side, but would have to check before making a definitive statement

[piepie62]

The tool works by taking the ID, species, form, and maybe gender (don't remember on that one) into account when it's building the database. Arceus's typed variants are actually different forms, though nothing in-game tells you that

[piepie62]

Yes, the gender is taken into account

[CornFlakes999]

As for the Vivillon, is there something that's showing up that's similar in the same way?

Yup, according to the Mystery Gift Repo, Paris Vivillon shares the same ID with the "Summer 2014" event. Which also made me notice another WC missing due to shared ID (In PKSM is the "0518 Pinsirite" is available, but the 0518 Heracrossite" not) But then again, Wondercard ID 0504 which gives either Electabuzz for Y or Magmar for X seems fine

[CornFlakes999]

The tool works by taking the ID, species, form, and maybe gender (don't remember on that one) into account when it's building the database. Arceus's typed variants are actually different forms, though nothing in-game tells you that

I see. Yeah, the Rockruff event is identical. only that for US it has "Fire Fang" as Move 3 and "Thunder Fang" on UM

[piepie62]

Hmph... the item brought up a good point that I was about to ask you about, actually. I'm thinking I might completely overhaul the way the packing tool works; it's currently a custom Python thing, but if I used PKSM's code itself then I wouldn't have any issues with taking all of this into consideration

[CornFlakes999]

Hmph... the item brought up a good point that I was about to ask you about, actually. I'm thinking I might completely overhaul the way the packing tool works; it's currently a custom Python thing, but if I used PKSM's code itself then I wouldn't have any issues with taking all of this into consideration

I can see if maybe I find more missing events due to the ID thing being the same. If that is helpful to have a list on it? By the way, just for your effort on this, I started a pledge on Patreon! That one should help general development I hope (:

[piepie62]

A list actually wouldn't be all that helpful, no. Thank you for the offer, though

[CornFlakes999]

Hmph... the item brought up a good point that I was about to ask you about, actually. I'm thinking I might completely overhaul the way the packing tool works; it's currently a custom Python thing, but if I used PKSM's code itself then I wouldn't have any issues with taking all of this into consideration

Maybe if the tool considers difference in the OT Name that would sort out a few missing events I guess. For example the 0511 Vivillon is mostly the same, but for the Paris one it has OT "Paris", while the other one has "SUM2014" But rockruff has the same OT (at least technically, because it gets set by the game after receiving). so only the move #3 is different here...

[CornFlakes999]

A list actually wouldn't be all that helpful, no. Thank you for the offer, though

Okay, sure. Maybe it wouldn't even that big of a list anyway if nobody has noticed missing events so far

[piepie62]

So, I've actually run into a bit of an issue. The way that PKSM builds would mean that using PKSM's code for the packer would require dependencies that I don't think are even available on the default devkitPro-updater provided environment. That would... not be great, to say the least, as then people would have to go through more complicated setup to build PKSM than "just install these packages"

[piepie62]

I'm not entirely certain how I should handle this without that, though.

[CornFlakes999]

I'm not entirely certain how I should handle this without that, though.

Hmm, I see. Well there is one thing I could think of. But I'm not sure if it's a valid idea or even more complicated. What if PKSM did a local storage for some of the missing events? You know similiar like the scripts are included in the PKSM (without extra installs). What if something similar would be used for for mystery gifts. By default it would still access the online library but there would also be some menu or button to access "local files". This would probably also have the side effect that users could place their own files into that directory

[piepie62]

Actually, PKSM basically does do that. Problem is, it still expects the packed format, and while you could shove everything into the packed format without the aliasing of different-language duplications to each other (that's the real point of the packer, by the way: that way we don't have to make some ridiculous hardcoded map that relates files to each other), that's not very easily doable

[piepie62]

The current general solution is to use the inject.c script to actually inject wonder cards of a user's choosing (from /3ds/PKSM/inject) into games, but I don't like having events that aren't actually duplicates being treated like they are duplicates, which is why I didn't just instantly send you to that solution and close this issue

[CornFlakes999]

I see... In an earlier message you mentioned, that your packer see wondercards as different, by taking species, form and gender into account. Wouldn't it be possible, by using that approach to also compare what moves a Pokemon has? Or the OT? for example the "Rockruff" is mostly the same, but the move3 is different. The wondercard is also game specific (One for US and one for UM), so there are some slight differences here. On the missing vivillon, I think its the Trainers name and OT that is different from the one currently being listed in PKSM

[CornFlakes999]

So if I understand coding right, we would need to find something in the wondercards, that tells your packer "This is different" without being completely rewritten, so it sees some of the wonders cards as 2 not 1. Right?

[piepie62]

"Wouldn't it be possible by using that approach to also compare what moves a Pokémon has?" That one would be fairly easy, yes. The OT would be more difficult, but also doable.

[piepie62]

The problem with things like the OT, though, is that if I were to just say "if the OTs are different, then the Wonder Card is different", then certain wonder cards that I would want to be considered the same, such as ones that have an OT difference between languages but everything else is the same, would be considered different

[CornFlakes999]

That one would be fairly easy, yes.

That one would add a whole bunch of events for GEN7 to start with. I just checked a few minutes ago on PKSM (because I got curious) For the 2018Legends events is a similar issue as with Rockruff. The Wondercard IDs are reused, but the Pokemon is supposed to be different depending on receiving game. Example: 2018 Legends Dialga. On UM it is level 100 and has a gold bottle cap along with different moves. But regular Moon got it at Lv. 60 with different moves, level and item. This applies to almost all 2018 Legends: Ultra games got higher levels and different moves of the same Pokemon

[CornFlakes999]

The problem with things like the OT, though, is that if I were to just say "if the OTs are different, then the Wonder Card is different", then certain wonder cards that I would want to be considered the same, such as ones that have an OT difference between languages but everything else is the same, would be considered different

Yeah! That makes sense! It would get cluttered if the multi-language cards would show up as duplicates in the default list (They would probably don't show duplicate if someone selects the language sorting at the bottom, but I'm not sure how frequently that is used, I myself usually just use the default list)

[CornFlakes999]

The problem with things like the OT, though, is that if I were to just say "if the OTs are different, then the Wonder Card is different", then certain wonder cards that I would want to be considered the same, such as ones that have an OT difference between languages but everything else is the same, would be considered different

I think I also found a possible solution, regarding Vivillon (and maybe some others that are affected the same way). Don't compare the OT name, but rather the OT ID. That should avoid the issues of un-grouping wondercards that belong together, but still add other events as different. (I attached the Vivillon details for example)

[CornFlakes999]

Hi Just checking in, are there any updates on this? Thanks!

[piepie62]

Honestly, still trying to think of a good way to handle this. I wouldn't be surprised if different-language WCs had different TIDs, given that the OT name is different, which means they wouldn't merge together if I tried that. Moves and items (including items on their own) should be fairly doable, but that doesn't solve your Vivillon problem.

[CornFlakes999]

I understand. Yes, if different-language WCs would be split up by this, it wouldn't be ideal. /: The Moves and Items check/comparison would probably bring around 99% of the currently missing events into it (like Rockruff, or the 2018Legends which re-use the ID but are different in Level and Moves between regular S/M and US/UM.)

I just tried to check on the TIDs. If the preview in PKSM is any indication it appears to stay the same when I tap on the available languages in the bottom screen. (I checked some 2018Legends and US/UM events) I try to be as helpful as possible here, so if it helps I have a spare X and a spare Ultra Moon that I could restart the game on and play it in a different language than English to see if events received there get the same TID like they get when I receive them on the English one or if they show as different? From my experience with most events, the visible Trainer ID is always the same, even if a different language or trainers name. If the ID is different, it's usually a different event. But I know that there are also some invisible IDs and numbers, so these could be different then... Also attached are some screen examples as shown in PKSM regarding the TID/SID shown, when changing the language on the bottom screen.

[piepie62]

Okay, I've gotten a program working with the proper formatting. It's a native application, though, so I'll have to figure out a good way to distribute it for building PKSM.

[CornFlakes999]

Okay, I've gotten a program working with the proper formatting. It's a native application, though, so I'll have to figure out a good way to distribute it for building PKSM.

Nice! That sounds promising. Thanks for the update. (: If there is anything I can check/test on my side, let me know. I got all XY Omega Ruby and a Alpha Sapphire along Moon, Sun and the Ultra games, so I can do further research on certain events if needed. Especially on those that appear the same but have slight differences between game version or like 2018Legends that are even more different between SM games and USUM games

[piepie62]

I have now integrated that program into PKSM's build system. I'll be uploading the changed database files to FlagBrew's website soon, which should change them for you via the automatic database updating (assuming you have automatic updates enabled).

[CornFlakes999]

Oh, wow! That is amazing! Yes, I can check it out now or as soon as you say it's updated. And yes, I think I have automatic updates enabled, it does say "Checking for updated event database" (or similar) every time on start up

[CornFlakes999]

which should change them for you via the automatic database updating (assuming you have automatic updates enabled).

I just checked in PKSM with Ultra Moon, to see about Thunder Fang Rockruff, but I still don't see it /: Am I doing something wrong here? At the start it does say "Checking for Update" and "Checking for updated gift database" and in settings it says "Automatically Update PKSM = Yes" Or is it better to go to the releases Page here and get the most recent one? in PKSM it says PKSM v8.0.3-ba2a8bdc

[piepie62]

Nope, I just haven't updated the database yet. I don't actually remember the process (whoops) and I'm waiting for our site programmer to get back to me on how to do that. Sorry about that!

[CornFlakes999]

Ah, I see. Well no rush then :) I just thought I had setup something wrong here on my end...

[CornFlakes999]

Today I finally come around to post a message. I got time to check the updated events and yes, they are all there! Thanks so much for fixing that! It's awesome. Besides the Vivillon and Rockruff that were most important to me, there are also a whole bunch of other events that show up in the list now. Especially with the 2018 Legends on Sun, Moon, Ultra... Previously only the Ultra variant events at Lv100 appeared, now I can also receive the ones on regular Sun on my game too Just awesome! :-)

[FM1337]

Closing this issue now as it appears to have been resolved, if it is not please feel free to re-open!