search

FlagBrew / PKSM

Gen I to GenVIII save manager.
GNU General Public License v3.0
1.72k stars 173 forks source link

Bug Report - Music is broken #1290

Closed obscurerev closed 1 year ago

obscurerev commented 3 years ago

Describe the bug Music listed in the Songs folder in the sdmc:/3ds/PKSM directory only plays for a split second before cutting completely.

To Reproduce Steps to reproduce the behavior:

  1. Open PKSM
  2. Wait for it to load
  3. Music plays for a split second.
  4. Music cuts and everything else loads normally.

Expected behavior Plays music normally upon entering the save menu.

Information about your environment

Additional context I have dumped the latest DSP1, I have tried renaming the file to something without any special characters and have tried putting multiple .mp3 files in the folder. All to no avail.

ghost commented 3 years ago

I’ve had a similar issue—but I had a bunch of files in it. Do your music files have Japanese naming on them? This homebrew I use for switch doesn’t support Japanese so I had to rename files in order to play them.

On Aug 5, 2021, at 1:51 PM, Ryan @.***> wrote:

 Describe the bug Music listed in the Songs folder in the sdmc:/3ds/PKSM directory only plays for a split second before cutting completely.

To Reproduce Steps to reproduce the behavior:

Open PKSM Wait for it to load Music plays for a split second. Music cuts and everything else loads normally. Expected behavior Plays music normally upon entering the save menu.

Information about your environment

OS version: 11.15 (North America) PKSM version: 9.2.0 Entrypoint: Luma3DS and/or B9DS or something like that Additional context I have dumped the latest DSP1, I have tried renaming the file to something without any special characters and have tried putting multiple .mp3 files in the folder. All to no avail.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

obscurerev commented 3 years ago

There's no Japanese characters on mine. Does yours work with or without an author listed? I used 3DShell to view the mp3 and it has an artist name.

ghost commented 3 years ago

They were mostly without author names, although one (your adventure by okazaki taiiku), had an author name. It didn’t play as well—(I moved the mp3s to my switch a few months ago, and they play fine using a sysmodule mp3 player, so anything would be on PKSM’s end)—so I assume artist names wouldn’t mess with playback.

On Aug 5, 2021, at 2:01 PM, Ryan @.***> wrote:

 There's no Japanese characters on mine. Does yours work with or without an author listed? I used 3DShell to view the mp3 and it has an artist name.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

obscurerev commented 3 years ago

So artist names don't have to do with this huh...? I don't know what could be causing it otherwise.

ghost commented 3 years ago

I don’t have a clue either. If you’re looking to play mp3s on a 3DS though, limeplayer (I think it’s called that) is a great choice that I used before I got my switch and hacked it. good luck man!

On Aug 5, 2021, at 2:09 PM, Ryan @.***> wrote:

 So artist names don't have to do with this huh...? I don't know what could be causing it otherwise.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

obscurerev commented 3 years ago

I already have an mp3 player on my 3ds. I just want mp3's to play in PKSM.

piepie62 commented 3 years ago

Do they all follow these recommendations from the wiki? Relatively small file sizes are recommended, as are sampling frequency of 44100Hz and a bitrate of 96kbps. If so, I'd need to look deeper into this

ghost commented 3 years ago

As for filesize, mine usually ranged from 2-6MB. I can’t check the sampling or bitrate however

On Aug 5, 2021, at 2:30 PM, Chris Feger @.***> wrote:

 Do they all follow these recommendations from the wiki? Relatively small file sizes are recommended, as are sampling frequency of 44100Hz and a bitrate of 96kbps. If so, I'd need to look deeper into this

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

obscurerev commented 3 years ago

I can't check the sampling bit-rate on mine, but let me tell you that the same exact mp3 file worked before a couple of months ago, but then it just stopped working entirely, along with any mp3 I put in. (also sorry for the late reply, I usually reply really late for these.)

piepie62 commented 3 years ago

I'm not sure what could be causing that, then. I haven't changed the sound handling code since at at least 9.0.0, which released over a year ago. My best guesses are that it's something wrong with the MP3 or possibly your SD card

obscurerev commented 2 years ago

even after nearly a year later, this issue is still a problem for me. I've tried wav, m4a, mp3 with album cover, mp3 without any album cover, songs that are not over a minute. nothing is working. It just plays for a second and cuts off.

mayamcdougall commented 2 years ago

Just started having this issue the other day. At first, I was worried it might be my SD card starting to fail, but that doesn't seem to be it.

I haven't made any changes to my PKSM setup, it's been exactly the same as it's always been (for several years), just suddenly now the music's broken.

So unless the 20 extra boxes of Pokemon I recently bred (in my attempt to learn to IV breed 😂) did something, I've got nothing to contribute here other than "same here". 😔

Edit: I also just tried reinstalling over PKSM, deleting the title and reinstalling, and temporarily restoring to a very old extdata backup (from several years ago). None of these had any impact on the behavior. I've also tried changing out the mp3 with a different one and the behavior is still the same (plays a half second, like the original post). I'll update this if I think of trying anything else.

Edit 2: Alright, so for my case at least, I've narrowed it down to an issue with Rehid. I'm not using any rehid button remapping with PKSM, but just having it installed (and thus always running in the background via Luma) breaks the music in PKSM. Probably should have been the first thing I tested, but I was convinced that the music broke on a different day than when I started using Rehid.

Was anyone else on this thread using Rehid or other Luma modules that could have interfered with PKSM?

It'd be really cool if there could be a workaround for this (because Rehid is legitimately pretty nice too), but I fully expect that, unless there's an actual PKSM bug behind it, this will be more of an out-of-scope issue. 😔

obscurerev commented 2 years ago

hm I never thought of rehid interfering with this, will try this out

obscurerev commented 2 years ago

doesn't work :(

mayamcdougall commented 2 years ago

Did you make sure to either completely remove Rehid from /luma/titles or disable Game Patching in Luma's settings (hold select while booting your 3DS)?

Actually, disabling Game Patching in general would also be a good way to double check that there's nothing else that could be interfering with PKSM either too. 🤔

GriffinG1 commented 1 year ago

I am going to go ahead and tentatively close this now that v10 has been released. @obscurerev if the issue persists in v10 please update here and I will reopen.

mayamcdougall commented 1 year ago

First off, congrats on the new release, and thank you to the team for working on it! I've been silently watching the commit history for the last year or more, waiting for the day that Gen 1/2 support might finally be released.

This is absolutely amazing! 😁

... but, I do also have to unfortunately confirm that this issue still occurs. 😒

In the comments above, @obscurerev never actually confirmed that they fully removed or disabled Rehid, or if they had any other Luma modules running. So, I still suspect that this issue is related to that. Rehid is a little difficult to remove, since Rehid Helper creates a lot of persistent files that could be easily overlooked.

It's probably out-of-scope to even fix this bug unless there's an obvious cause (eg, some kind of oversight), since it seems to be triggered by other homebrew running.

Anyway, not complaining, just trying to keep things documented. 😉

Congrats again on the v10 release! 🎉❤️

obscurerev commented 1 year ago

I am glad to say that deleting the rehid folder actually fixed the issue! I'm sorry for this late response, but I thank everyone who has helped me with this issue. Also congrats on 10.0 🥳

mayamcdougall commented 1 year ago

Cool, so it's officially narrowed down to a compatibility issue with Rehid.

Now... if only we could have both... 👀😅