FlagBrew / PKSM

Gen I to GenVIII save manager.
GNU General Public License v3.0
1.75k stars 176 forks source link

Bug Report - Cancelling Pokemon storage fails to return Pokemon to save file #1399

Closed intaiyjw closed 1 year ago

intaiyjw commented 1 year ago

Describe the bug When cancelling the prior transferring actions between storage of PKSM and box of a save file, the cancelling action only functioned on the PKSM storage, but not the save file, which led to unexpected Pokemon deletion.

To Reproduce Steps to reproduce the behavior:

  1. Open a save file
  2. Click on 'Storage' in lower screen
  3. Move the Pokemon in the lower save file to upper PKSM storage
  4. Press 'B' button, and press 'B' again to cancel the changes made to storage
  5. Press 'Storage' to get back again, and we can see the Pokemon disappeared, which should have been returned to the save file. In other word, the 'cancel' action did function on the the storage, but fail on the save file (i.e., PKSM storage gave up receiving Pokemon, but did NOT return them).

Expected behavior After 'B' button is pressed to cancel the action, the Pokemon that PKSM temporarily held should have been returned to save file. But in fact it did not.

Screenshots If applicable, add screenshots to help explain your problem.

Information about your environment

Additional context The unexpected result of Pokemon deletion is literally depressing!!!

GriffinG1 commented 1 year ago

Working as intended. Exit pksm without applying changes to the save to return those Pokemon.

intaiyjw commented 1 year ago

But mine did not. What should I do, please?

GriffinG1 commented 1 year ago

Again, the application is working as intended. Not saving changes to storage does not affect save changes at all. It's a way for bulk deletions.

Provided you didn't disable the setting, PKSM makes automatic backups in ~/3ds/PKSM/backup/. Either restore one with Checkpoint, or enable the inject save option in PKSM's settings along with the view backups setting and use that to restore it.