FlagBrew / PKSM

Gen I to GenVIII save manager.
GNU General Public License v3.0
1.72k stars 173 forks source link

Bug Report - Items get "deleted" #1411

Open Diverscope opened 1 year ago

Diverscope commented 1 year ago

Describe the bug When editing the contents of the bag of a gen4 Pokémon game and you delete one or multiple items, several items at the end of the bag (i.e the items at the very bottom) get "deleted". Deleted in quotation marks because they actually don't seem to get deleted, just hidden or not accessible ingame. If you add an item in the bag afterwards and reopen the bag menu in pksm, suddenly some or all of the missing items appear again.

To Reproduce Steps to reproduce the behavior:

  1. Open pksm and load a gen4 save file
  2. Select the bag option in the menu
  3. Go to the item list, tap at one item and change it to "(None)" (thus deleting the item)
  4. Save the game
  5. Several items should vanish from the particular section (ie. Poké Balls) of the bag (both in pksm and ingame)
  6. Readd an item by selecting the bag option again, scroll down the list and change the "(None)" entry to any other item
  7. One or more items should reappear again. If not, go back to the menu and select "Bag" again

Expected behavior If deleting an item by changing it to "(None)", it should delete the item and only this item. All the other items will move up a slot, but will not be tempered otherwise.

Information about your environment

Additional context I don't know the official english terms of pksm since I'm using the german translation. I'm also not 100% sure if you're supposed to change an item to "(None)" in order to delete it. Might be a dirty way and pksm doesn't like that at all.