FlagBrew / PKSM

Gen I to GenVIII save manager.
GNU General Public License v3.0
1.71k stars 173 forks source link

Bug Report - Incorrect conversion from Omega Ruby to HeartGold #852

Closed Masamune3210 closed 5 years ago

Masamune3210 commented 5 years ago

Describe the bug Have a Gulpin that when copied from Omega Ruby to HeartGold, looses it's OT name.

To Reproduce Steps to reproduce the behavior:

  1. Download uploaded save
  2. Copy Gulpin from Box 1 to storage, then from storage to HeartGold
  3. Notice the missing OT
  4. See error

Expected behavior OT to be perserved

Screenshots If applicable, add screenshots to help explain your problem.

Information about your environment

Additional context Add any other context about the problem here. Will upload the save file in a hour or so when I can get to my computer

EDIT - Forgot to mention, in the hex editor it has FF at the start of the OT field, I'm assuming a terminator

EDIT - Uploaded files Saves

Admiral-Fish commented 5 years ago

Please upload the before and after pkm files

Masamune3210 commented 5 years ago

Sorry ,got busy yesterday, will upload later today

Masamune3210 commented 5 years ago

Uploaded files finally, sorry for the wait

Admiral-Fish commented 5 years ago

Was able to replicate. Looks like it might have something to do with how long the OT name is. Will investigate more.

Masamune3210 commented 5 years ago

Could it also have anything to do with the pokemon coming from a non english game?

Masamune3210 commented 5 years ago

Issue is resolved with point update, OT os shortened but I'm assuming its due to other name limit in gen 4