search

FlagOpen / FlagEmbedding

Retrieval and Retrieval-augmented LLMs
MIT License
7.64k stars 554 forks source link

Found a bug! #1160

Open greeneggsandyaml opened 3 weeks ago

greeneggsandyaml commented 3 weeks ago

Tricky bug, and doesn't result in an error because for-else is valid in python.

https://github.com/FlagOpen/FlagEmbedding/blob/dc2170d46fab2ecb5631317dc1924aae0229c84a/FlagEmbedding/llm_dense_retriever/finetune/data.py#L270-L274

545999961 commented 3 weeks ago

Thank you very much for pointing out the bug!

greeneggsandyaml commented 3 weeks ago

Of course, happy to help!