search

Flagsmith / flagsmith-charts

Helm Charts for Flagsmith. Feature flagging and remote config service. Host yourself or use our hosted version.
https://www.flagsmith.com/
Other
36 stars 31 forks source link

Incorrect PGBOUNCER secret password parsing #163

Open flex-seongbok opened 8 months ago

flex-seongbok commented 8 months ago

Hi, thanks for maintaining this project. We encountered problem while testing PgBouncer.

https://github.com/Flagsmith/flagsmith-charts/blob/0cf91203da115c256efbce43db4a79cbac0e0fac/charts/flagsmith/templates/secrets-pgbouncer.yaml#L14

secrets-pgbouncer.yaml parses databaseUrl using urlParse to get host, database, user, password seperately. but urlParse escapes url and results in incorrect password configuration if there is databaseUrl like postgresql://{user}:password!123@{host}:{port}/{database_name} This url transformed in secrete as password%21(base64 decoded) such as url escaped string Other special characters could make error at urlParse

dabeeeenster commented 8 months ago

Thanks for the heads up - are you able to provide a PR?

flex-seongbok commented 8 months ago

Thanks for the heads up - are you able to provide a PR?

I'm not used to writing helm template and go, so not confident that I can write correct patch, sorry.

dabeeeenster commented 8 months ago

OK we will take a look when we have a chance