search

Flagsmith / flagsmith-dotnet-client

.NET Standard Client for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://www.flagsmith.com/
https://www.flagsmith.com/
BSD 3-Clause "New" or "Revised" License
19 stars 15 forks source link

Question: Cancellation token for async methods #87

Open HHHackGit opened 10 months ago

HHHackGit commented 10 months ago

Hi! FlagsmithClient contains many asynchronous methods without CancellationToken support. Are there any plans to add CancellationToken to the methods? Thanks for answer!

dabeeeenster commented 10 months ago

One for @novakzaballa

novakzaballa commented 10 months ago

Hi @HHHackGit , thank you for your feedback! In general, we try to maintain a seamless behavior among our different SDKs. Some of the async tasks in the .Net client already incorporate embedded logic to handle timeouts, errors, and calls to the dispose() method by using CancellationToken. So far it seems that the users' needs are covered by this internal logic. Please let us know if you would like to be able to provide your own cancellation token for specific methods, justifying that with use cases or scenarios. so we can see if that can be supported by the existing logic or we should implement it for .Net and other clients. It would be great if you could add those scenarios in the description of this issue.