Closed matthewelwell closed 1 year ago
File | Coverage | |
---|---|---|
All files | 100% |
:white_check_mark: |
Minimum allowed coverage is 100%
Generated by :monkey: cobertura-action against d02885eeea8655861b33337c848eb83c841ffb8b
Finalised the work:
computed_field
for IdentityModel.composite_key
model_validate
instead of parse_obj
, model_dump
instead if dict
Switched typeguard
usage to type_annotations.TypeGuard
type instead.
Closing in favour of https://github.com/Flagsmith/flagsmith-engine/pull/190 to allow @matthewelwell to review.
Update to pydantic V2. What I've done so far:
pydantic
andpydantic-collections
dependencies usingpip-tools
pip install bump-pydantic && bump-pydantic flag_engine
root_validator
method_generate_default_composite_key
on theIdentityModel
with acomputed_field
namedcomposite_key
.typeguard
dependency and changedif isinstance(value, TRAIT_VALUE_TYPES)
tocheck_type(value, TRAIT_VALUE_TYPES)