Improve useFlagsmithLoading

Flagsmith / flagsmith-js-client

Javascript Client for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://www.flagsmith.com/

https://www.flagsmith.com/

BSD 3-Clause "New" or "Revised" License

60 stars 38 forks source link

Improve useFlagsmithLoading #182

Closed kyle-ssg closed 1 year ago

kyle-ssg commented 1 year ago

It was raised that useFlagsmithLoading was not working appropriately in the case where there was an error

the values of isFetching and isLoading in the case that a feature is not found by name in the API are always true, and there is no error.

Also, there is no explicit workflow or state change flow defined in the docs.

Acceptance Criteria

When we request a feature name that doesn't exist, the values of isFetching and isLoading should be set to False after we determine it does not exist