search

Flagsmith / flagsmith-js-client

Javascript Client for Flagsmith. Ship features with confidence using feature flags and remote config. Host yourself or use our hosted version at https://www.flagsmith.com/
https://www.flagsmith.com/
BSD 3-Clause "New" or "Revised" License
60 stars 38 forks source link

Support `getValue` fallback without `json` flag #212

Closed levrik closed 8 months ago

levrik commented 8 months ago

The fallback option of getValue is currently being ignored without the json flag being set. I'm not seeing any reason for not supporting fallback in this case but I might be missing something.

I'm open to contribute this change also myself if a maintainer agrees.

zachaysan commented 8 months ago

Hey Levrik feel free to open up a PR with the fix if you're able to!

levrik commented 8 months ago

@zachaysan Done