Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.77k stars 365 forks source link

fix: Stale connections after task processor errors #4179

Closed khvn26 closed 3 months ago

khvn26 commented 3 months ago

Thanks for submitting a PR! Please check the boxes below:

Changes

This fixes a problem surfaced in one of the on-prem environments when task processor wouldn't recover during database failover.

How did you test this code?

Manually in the on-prem environment where the problem was reproduced.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/7Cs4Toutjfah9Q7CeoMuEJcTovy2)) | [Visit Preview](https://docs-git-fix-stale-connections-after-task-proc-4bb1e6-flagsmith.vercel.app) | | Jun 18, 2024 7:08pm | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/hCKVFXk7aNYgNWm2JoTU6V4QsLmd)) | [Visit Preview](https://flagsmith-frontend-preview-git-fix-stale-conne-ed83bb-flagsmith.vercel.app) | | Jun 18, 2024 7:08pm | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/HBooyH4mAZPNsx2vVyeYMWmiNLb1)) | [Visit Preview](https://flagsmith-frontend-staging-git-fix-stale-conne-1003b7-flagsmith.vercel.app) | | Jun 18, 2024 7:08pm |
github-actions[bot] commented 3 months ago

Uffizzi Preview deployment-53151 was deleted.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.50%. Comparing base (b7c4f5f) to head (58746e0). Report is 6 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4179 +/- ## ========================================== - Coverage 96.50% 96.50% -0.01% ========================================== Files 1177 1177 Lines 38217 38215 -2 ========================================== - Hits 36883 36881 -2 Misses 1334 1334 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.