Closed novakzaballa closed 3 months ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flagsmith-frontend-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 24, 2024 2:36pm |
flagsmith-frontend-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 24, 2024 2:36pm |
Uffizzi Preview deployment-53181
was deleted.
@novakzaballa I've released the SAML fix that you created to staging so this can now be tested correctly against staging, but I've found a few issues:
saml_configuration=0
(see screenshot 1 below)
- It should be possible to add attributes as part of the creation workflow (or at least the modal shouldn't auto close)
Now the modal does not close when the configuration is created, and the SAML attribute tab displays immediately.
- The FE is making an invalid request initially when opening the edit modal to retrieve the mappings for
saml_configuration=0
(see screenshot 1 below)
Corrected
- The UI doesn't handle long IdP attributes (see screenshot 2 below - note that this is a very valid attribute and is used in a lot of our customer's configurations)
Done
- The attributes aren't editable but appear like they are (as it shows a pointer when you hover over each row in the table). I guess making them editable would be tricky given the fact that we're already in a modal, so perhaps we should just remove the pointer on hover?
Removed.
The overflow issue still isn't resolved. The key thing we need to solve it for is not multiple words, but a single long URL. The test case you used is not really valid.
I've fixed this here but I'm seeing weird behaviour on the tooltip. It looks like the container for the tooltip itself isn't wide enough for the string but I have no idea how to resolve that...
I've fixed this but I'm seeing weird behaviour on the tooltip. It looks like the container for the tooltip itself isn't wide enough for the string but I have no idea how to resolve that...
Done
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
How did you test this code?