Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.77k stars 365 forks source link

fix: not serializable arguments when calling environment feature version webhooks #4187

Closed matthewelwell closed 3 months ago

matthewelwell commented 3 months ago

Thanks for submitting a PR! Please check the boxes below:

Changes

Fixes an issue with non-serializable arguments passed to the call_environment_webhooks function.

How did you test this code?

Updated the existing unit test.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/HTBnPryvESNnzeyAydNnzEtc4aqk)) | | | Jun 19, 2024 7:42am | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/HuA2q9dxkKxySzmBvqAR4jrTNkXN)) | | | Jun 19, 2024 7:42am | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/FUWd9PHjGHSVPEqkaWT1dgUL6Q9w)) | | | Jun 19, 2024 7:42am |
github-actions[bot] commented 3 months ago

Uffizzi Ephemeral Environment deployment-53201

:cloud: https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4187

:page_facing_up: View Application Logs etc.

What is Uffizzi? Learn more!

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.51%. Comparing base (17782bd) to head (20a01e8). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4187 +/- ## ======================================= Coverage 96.50% 96.51% ======================================= Files 1177 1177 Lines 38215 38230 +15 ======================================= + Hits 36881 36896 +15 Misses 1334 1334 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.