feat: Use environment feature state instead of fetching feature states

Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/

https://flagsmith.com/

BSD 3-Clause "New" or "Revised" License

4.77k stars 365 forks source link

feat: Use environment feature state instead of fetching feature states #4188

Closed kyle-ssg closed 1 month ago

kyle-ssg commented 3 months ago

Thanks for submitting a PR! Please check the boxes below:

[x] I have run pre-commit to check linting
[x] I have added information to docs/ if required so people know about the feature!
[x] I have filled in the "Changes" section below?
[x] I have filled in the "How did you test this code" section below?
[x] I have used a Conventional Commit title for this Pull Request

Changes

In order for the feature list page to function, it needs access to the features and feature states.

Prior to this the frontend got all feature states when fetching features and matched them up. Now that the backend returns the feature states in the features, this PR adjusts the Frontend to use that rather than fetching them.

Resolves #3301

How did you test this code?

Filtered , created and updated features
Created and updated versioned features
Created and updated MV features

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2024 4:59pm
flagsmith-frontend-preview	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2024 4:59pm
flagsmith-frontend-staging	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 7, 2024 4:59pm

github-actions[bot] commented 3 months ago

Uffizzi Preview deployment-54841 was deleted.

novakzaballa commented 2 months ago

@kyle-ssg why we don't use the RTK here?

kyle-ssg commented 2 months ago

It’ll be very difficult to migrate this given how integral and widely used it is. Though I did make versioning use it to make it easier when we do.

github-actions[bot] commented 2 months ago

Docker builds report

Image	Build Status	Security report
`ghcr.io/flagsmith/flagsmith-api-test:pr-4188`	Finished :white_check_mark:	Skipped
`ghcr.io/flagsmith/flagsmith-e2e:pr-4188`	Finished :white_check_mark:	Skipped
`ghcr.io/flagsmith/flagsmith-api:pr-4188`	Finished :white_check_mark:	Results :white_check_mark:
`ghcr.io/flagsmith/flagsmith-private-cloud:pr-4188`	Finished :white_check_mark:	Results :white_check_mark:
`ghcr.io/flagsmith/flagsmith:pr-4188`	Finished :white_check_mark:	Results :white_check_mark:
`ghcr.io/flagsmith/flagsmith-frontend:pr-4188`	Finished :white_check_mark:	Results :white_check_mark: