Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.77k stars 365 forks source link

refactor: replace task processor #4189

Closed matthewelwell closed 2 months ago

matthewelwell commented 3 months ago

Thanks for submitting a PR! Please check the boxes below:

Changes

Replace the Task Processor code (which is currently split between this repo and https://github.com/Flagsmith/flagsmith-task-processor) with a direct poetry dependency instead.

How did you test this code?

All the unit tests have been moved to the task-processor repository. There are tests through this repo that still test the integration with the task processor.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 11:09am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 11:09am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 12, 2024 11:09am
github-actions[bot] commented 3 months ago

Uffizzi Preview deployment-53213 was deleted.

matthewelwell commented 3 months ago

Converting to draft to:

  1. ~Fix isort issues~
  2. ~Wait until I can bump to 1.0.0 (which requires an update in flagsmith-workflows)~
codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.77%. Comparing base (759e745) to head (6b8c827). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4189 +/- ## ========================================== + Coverage 96.61% 96.77% +0.16% ========================================== Files 1196 1159 -37 Lines 39123 38069 -1054 ========================================== - Hits 37797 36842 -955 + Misses 1326 1227 -99 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 months ago

flagsmith-frontend image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-frontend:pr-4189 Finished :white_check_mark: Results :white_check_mark:
github-actions[bot] commented 2 months ago

flagsmith-api image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-api:pr-4189 Finished :white_check_mark: Results :white_check_mark:
github-actions[bot] commented 2 months ago

flagsmith-private-cloud image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4189 Finished :white_check_mark: Results :white_check_mark:
github-actions[bot] commented 2 months ago

flagsmith image build and security scan finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith:pr-4189 Finished :white_check_mark: Results :white_check_mark:
github-actions[bot] commented 2 months ago

flagsmith-e2e image build finished :sparkles:

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4189 Finished :white_check_mark: Skipped
github-actions[bot] commented 2 months ago

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4189 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4189 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-frontend:pr-4189 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-api:pr-4189 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4189 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4189 Finished :white_check_mark: Results :white_check_mark:
matthewelwell commented 2 months ago

I have verified that there haven't been any more changes in the task_processor module in this repo. Once CI passes, I will merge.