Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.77k stars 365 forks source link

fix: Include free plans for api use notifications #4204

Closed zachaysan closed 3 months ago

zachaysan commented 3 months ago

Thanks for submitting a PR! Please check the boxes below:

Changes

Includes free plans in the API use notifications with a rolling 30 day window as their effective start date. It also included some extra code to ensure that they're not including in automatic payment adjustments since free plans don't have credit cards.

How did you test this code?

Two existing tests and a new one just for free plans.

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/GKEULKisEL9g6TNrmtgzSqUuyX5s)) | [Visit Preview](https://docs-git-fix-includefreeplansforapiusenotifications-flagsmith.vercel.app) | | Jun 20, 2024 6:43pm | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/HzU8FHVRoG5ko9RDFpiNDgEBkC8N)) | [Visit Preview](https://flagsmith-frontend-preview-git-fix-includefree-d95c52-flagsmith.vercel.app) | | Jun 20, 2024 6:43pm | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/9LXiBWCR5pdx3hHu6YZvuUdD7bYg)) | [Visit Preview](https://flagsmith-frontend-staging-git-fix-includefree-283ce8-flagsmith.vercel.app) | | Jun 20, 2024 6:43pm |
github-actions[bot] commented 3 months ago

Uffizzi Preview deployment-53292 was deleted.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.51%. Comparing base (e7fd8bd) to head (f491c2f). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4204 +/- ## ======================================= Coverage 96.51% 96.51% ======================================= Files 1177 1177 Lines 38230 38290 +60 ======================================= + Hits 36896 36956 +60 Misses 1334 1334 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.