Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

feat: Announcement feature flag per page #4218

Closed novakzaballa closed 4 days ago

novakzaballa commented 1 week ago

Thanks for submitting a PR! Please check the boxes below:

Changes

How did you test this code?

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 4:10pm
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 27, 2024 4:10pm
1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/9znNgd5PjveHEtH1MmVS8Vt6s8tj)) | [Visit Preview](https://docs-git-feat-announcement-feature-flag-per-page-flagsmith.vercel.app) | | Jun 27, 2024 4:10pm |
github-actions[bot] commented 1 week ago

Uffizzi Preview deployment-53413 was deleted.

matthewelwell commented 1 week ago

@novakzaballa I think we discussed creating a different component for this. What made you change your mind? If we stick with the announcement feature, I think we want to consider a couple of extra things:

  1. Should we allow the value to be a list as well as an object, and handle the typing in the code? This would be a bit ugly, but it would allow us flexibility in the future while maintaining backwards compatibility.
  2. Should we add another new attribute which is e.g. "allow_dismiss" that we can set to false for announcements that we want to ensure are permanent?