Closed novakzaballa closed 4 days ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Comments | Updated (UTC) |
---|---|---|---|---|
flagsmith-frontend-preview | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 27, 2024 4:10pm |
flagsmith-frontend-staging | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Jun 27, 2024 4:10pm |
Uffizzi Preview deployment-53413
was deleted.
@novakzaballa I think we discussed creating a different component for this. What made you change your mind? If we stick with the announcement feature, I think we want to consider a couple of extra things:
"allow_dismiss"
that we can set to false for announcements that we want to ensure are permanent?
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
Now the UI can read a list of pages from the
announcement_per_page
feature flag and display the announcement only on those pages, this is the pages name list:login not-found signup home github-setup maintenance password-reset features change-requests scheduled-changes change-request scheduled-change widget invite invite-link broken oauth saml environment-settings sdk-keys integrations users user-id user create-environment project-settings-in-environment compare feature-history feature-history-detail project-settings permissions segments organisation-settings organisation-permissions organisation-usage organisation-settings-redirect organisation-projects account-settings audit-log organisations audit-log-item create-organisation project-redirect account
How did you test this code?
announcement_per_page
FF with a new key named "pages", and add it the page names for example: ["segments", "users"]