Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

ci: add build script to frontend package.json #4219

Closed adgad closed 6 days ago

adgad commented 1 week ago

Thanks for submitting a PR! Please check the boxes below:

Changes

Currently when deploying Flagsmith to Heroku, the frontend fails to start because the build step hasn't run.

Heroku will automatically run a build script from the package.json, so adding this alias will allow the app to be deployed to Heroku with the node.js buildpack.

https://devcenter.heroku.com/articles/nodejs-support#customizing-the-build-process

How did you test this code?

Deployed a fork with this line to Heroku, using the heroku/nodejs buildpack, and confirmed the build step ran and the app worked as expected.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/GcMtGrQL7ZP7AoE13nBGzn8jtetf)) | [Visit Preview](https://docs-git-fork-financial-times-add-heroku-build-step-flagsmith.vercel.app) | | Jun 25, 2024 8:34am |
vercel[bot] commented 1 week ago

@adgad is attempting to deploy a commit to the Flagsmith Team on Vercel.

A member of the Team first needs to authorize it.

matthewelwell commented 1 week ago

Thanks a lot for this @adgad ! I've updated the title to conform to our conventional commit restrictions (you can see them here). I'll re-run the workflows and get this merged as soon as we can.

github-actions[bot] commented 1 week ago

Uffizzi Preview deployment-53442 was deleted.