Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

fix: versioning webhooks and update test to correctly test end to end #4221

Closed matthewelwell closed 1 week ago

matthewelwell commented 1 week ago

Thanks for submitting a PR! Please check the boxes below:

Changes

Fixes an issue with the webhooks for environment feature versions that was supposed to be fixed in #4187 but, because the test was just mocking the call to call_environment_webhooks, that was not the case. This PR fixes it properly and updates the test to run the full end to end webhook flow.

How did you test this code?

Updated existing test.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/DrS3N7xdz4CiUqRvec2ev1YgMwUN)) | | | Jun 25, 2024 10:14am | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/FMQ2CwQL7xPCukmBoybeiFtuHXiZ)) | | | Jun 25, 2024 10:14am | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/2RMuxqNsiMtJfb52Wj61wrR7Tvyz)) | | | Jun 25, 2024 10:14am |
github-actions[bot] commented 1 week ago

Uffizzi Preview deployment-53445 was deleted.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (5c25c41) to head (10ae7c0). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4221 +/- ## ======================================= Coverage 96.57% 96.57% ======================================= Files 1190 1190 Lines 38747 38754 +7 ======================================= + Hits 37419 37426 +7 Misses 1328 1328 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.