Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

fix(ci): Enable Docker builds and E2E for external PRs #4224

Closed khvn26 closed 1 week ago

khvn26 commented 1 week ago

Thanks for submitting a PR! Please check the boxes below:

Changes

This does a few things:

How did you test this code?

Tested the Makefile change locally. The rest of the changes will be tested in CI.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/3vs1FoZY2Dys5o8dRUeXes5XCBkn)) | [Visit Preview](https://docs-git-fix-docker-build-external-contributors-flagsmith.vercel.app) | | Jun 25, 2024 0:31am | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/6fN2uRwHzRDR6NLzL7ascgJwiHaz)) | [Visit Preview](https://flagsmith-frontend-preview-git-fix-docker-buil-b61a5c-flagsmith.vercel.app) | | Jun 25, 2024 0:31am | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/B8dNPe9S7pkuFp3ozMKMUS4Q2WDu)) | [Visit Preview](https://flagsmith-frontend-staging-git-fix-docker-buil-d63e3e-flagsmith.vercel.app) | | Jun 25, 2024 0:31am |
github-actions[bot] commented 1 week ago

Uffizzi Preview deployment-53456 was deleted.

matthewelwell commented 1 week ago

Remove Private cloud E2E for PRs for now. When we have Private cloud-specific E2E scenarios, we'll be able to run them by adding a E2E job depending on private-cloud build.

So I guess we'll still run them against the private-cloud image on a merge to main?

khvn26 commented 1 week ago

So I guess we'll still run them against the private-cloud image on a merge to main?

Yes we will.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (47eb149) to head (182cef2). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4224 +/- ## ======================================= Coverage 96.57% 96.57% ======================================= Files 1190 1190 Lines 38754 38754 ======================================= Hits 37426 37426 Misses 1328 1328 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.