Closed khvn26 closed 1 week ago
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Uffizzi Preview deployment-53456
was deleted.
Remove Private cloud E2E for PRs for now. When we have Private cloud-specific E2E scenarios, we'll be able to run them by adding a E2E job depending on private-cloud build.
So I guess we'll still run them against the private-cloud image on a merge to main?
So I guess we'll still run them against the private-cloud image on a merge to main?
Yes we will.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 96.57%. Comparing base (
47eb149
) to head (182cef2
). Report is 3 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Thanks for submitting a PR! Please check the boxes below:
pre-commit
to check lintingdocs/
if required so people know about the feature!Changes
This does a few things:
private-cloud
build.secrets: inherit
for the release/merge to main E2E run so errors are reported to Slack correctly.How did you test this code?
Tested the Makefile change locally. The rest of the changes will be tested in CI.