Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

chore(ci): Login to both registries for E2E #4233

Closed khvn26 closed 1 week ago

khvn26 commented 1 week ago

Thanks for submitting a PR! Please check the boxes below:

Changes

This PR simplifies the E2E workflow to expect both types of images and logging in to both GHCR and Depot registries regardless of the input.

The conditional input I've set up earlier didn't work as expected.

How did you test this code?

This is a CI change.

vercel[bot] commented 1 week ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/pQvVXpMPn8VGJgR9K9SKKmvC2umV)) | | | Jun 25, 2024 4:53pm | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/HwQeswSzzkE6pcbq5haCsammDYQc)) | | | Jun 25, 2024 4:53pm | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/BF8im3LwnXXre3igCT5pm6yZAD3c)) | | | Jun 25, 2024 4:53pm |
github-actions[bot] commented 1 week ago

Uffizzi Preview deployment-53484 was deleted.

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (23ada11) to head (0debd95).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4233 +/- ## ======================================= Coverage 96.57% 96.57% ======================================= Files 1190 1190 Lines 38754 38754 ======================================= Hits 37426 37426 Misses 1328 1328 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.