Create Feature, Create Segment and Edit Segment modals cannot always be closed with Esc - Githubissues

Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/

https://flagsmith.com/

BSD 3-Clause "New" or "Revised" License

4.56k stars 345 forks source link

Create Feature, Create Segment and Edit Segment modals cannot always be closed with Esc #4234

Open rolodato opened 1 week ago

rolodato commented 1 week ago

How are you running Flagsmith

[ ] Self Hosted with Docker
[ ] Self Hosted with Kubernetes
[X] SaaS at flagsmith.com
[ ] Some other way (add details in description below)

Describe the bug

Haven't found a pattern, but sometimes the Create Feature, Create Segment and Edit Segment modals cannot be closed using the Escape key.

Steps To Reproduce

Randomly open and close modals until you can't close them with Esc anymore:

https://github.com/Flagsmith/flagsmith/assets/829698/646bb1c8-940b-4054-bbdb-0296ca076fb0

https://github.com/Flagsmith/flagsmith/assets/829698/df78afc4-1d57-4124-a982-ad919f2249fb

Expected behavior

All modals should always be closable using Escape.

Screenshots

No response