Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

"No changes found" shown in already-applied change requests #4235

Open rolodato opened 1 week ago

rolodato commented 1 week ago

How are you running Flagsmith

Describe the bug

When viewing a change request or scheduled change, we show a diff of the changes that will be applied:

image

However, after the change request is applied, we show a banner with "No Changes Found":

image

This is misleading as it gives the impression that this change request contains no changes, which should be impossible.

Steps To Reproduce

  1. Schedule a feature to be enabled
  2. Publish the change
  3. View the scheduled change again

Expected behavior

A scheduled change's diff should be relative to the state of features at the time the change was created, not to the current state of the feature.

I don't know if this information is stored to begin with, which might be tricky. If that's not possible, we should remove the "No changes found" message altogether.

Screenshots

No response