Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

Do not provide a default date for scheduled changes #4238

Open rolodato opened 1 week ago

rolodato commented 1 week ago

How are you running Flagsmith

Describe the bug

When creating a scheduled change or change request, we provide the current time as the default go-live time:

image

For change requests that require approval, this might be okay but it's not immediately obvious what will happen if the approval happens after this date.

For scheduled changes that do not require approval, this does not make sense and we should force users to explicitly choose a go-live date.

Steps To Reproduce

Schedule a change or create a change request for any feature.

Expected behavior

When creating a scheduled change that does not require approval: do not populate any time and make users choose one. We cannot and should not suggest a default value here. Using the "Clear" button should clear any selected date and not allow users to proceed until they do choose a date.

When creating a change request that does require approval, default to the current date but make this explicit as a special case shown as "Immediately". Using the "Clear" button should reset this to show "Immediately" as well. Other wording could be "Immediately after approval". Open to consider alternate combinations of wordings or updating the "Schedule Change" field label as well.

Screenshots

No response