Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

Warn when creating empty change requests #4240

Open rolodato opened 1 week ago

rolodato commented 1 week ago

Is your feature request related to a problem? Please describe.

It's possible to create change requests that do not make any changes, by editing a feature and clicking "Schedule Update" without making any other changes. This is error-prone and can cause a nasty surprise when the go-live date for a feature arrives and nothing happens.

The only valid use case I can think for this would be to ensure a feature gets modified at a certain date, while other changes are being made or scheduled before this cutoff date. This seems like a valid but very fringe use case.

Describe the solution you'd like.

Add a mandatory confirmation step when creating a change request or scheduled change that makes no modifications to the current environment.

Describe alternatives you've considered

  1. Show a warning banner - this could get missed, and the potential impact of missing it IMO is far worse than the possible annoyance of adding one more click to this workflow. Also becomes annoying if we need other info/warning banners for anything else on the same screen
  2. Don't allow creating change requests that don't make any changes to the environment, by e.g. disabling the "create change request" or "schedule change" button if no changes to the feature were made. I would be also be okay with this solution until we can prove that there's a real customer need for creating change requests that don't make any changes.

Additional context

No response