Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

feat(api usage): Extra Flagsmith checks for API overage charges #4251

Closed zachaysan closed 6 days ago

zachaysan commented 6 days ago

Changes

This is a simple change to introduce another Flagsmith feature check for one of the more dangerous tasks that we have in the API usage alerting code.

How did you test this code?

The change also fixes a number of tests that broke with the change and introduces a large test for checking whether the Flagsmith client will successfully guard against non-use when disabled.

vercel[bot] commented 6 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/AEppfG9GV2qhWTEZGGfrg25Kk4rh)) | | | Jun 26, 2024 3:39pm | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/7HtzEv8JFi94mmz9AGxV2ED52gKM)) | | | Jun 26, 2024 3:39pm | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/4ksW5Lciz3PSujJxkJVuog7VfPMz)) | | | Jun 26, 2024 3:39pm |
github-actions[bot] commented 6 days ago

Uffizzi Preview deployment-53537 was deleted.

codecov[bot] commented 6 days ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 96.57%. Comparing base (182ea04) to head (fef930f). Report is 3 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4251 +/- ## ======================================= Coverage 96.57% 96.57% ======================================= Files 1190 1190 Lines 38754 38804 +50 ======================================= + Hits 37426 37476 +50 Misses 1328 1328 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.