search

Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.56k stars 345 forks source link

feat: WIP - Create change requests for segments #4265

Open zachaysan opened 4 days ago

zachaysan commented 4 days ago

Changes

I'm working through creating change requests for segments on both this repository and on the workflows one. I'm going to try to keep WIP PRs to avoid losing my work if there is data loss.

How did you test this code?

Tests still required, although most of it will eventually live in the workflows repository.

vercel[bot] commented 4 days ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Ignored Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/H7qfZr9VbyVs6Dv7qZFJgrwExazq)) | [Visit Preview](https://docs-git-feat-createchangerequestsforsegments-flagsmith.vercel.app) | | Jul 1, 2024 1:28pm | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/HssXwiVfLsfysn983XX9MdE7pQi3)) | [Visit Preview](https://flagsmith-frontend-preview-git-feat-createchan-b0889e-flagsmith.vercel.app) | | Jul 1, 2024 1:28pm | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/7h3jRXXm3V1zEUhf9PoDsaa3mMPa)) | [Visit Preview](https://flagsmith-frontend-staging-git-feat-createchan-1d3744-flagsmith.vercel.app) | | Jul 1, 2024 1:28pm |
github-actions[bot] commented 4 days ago

Uffizzi Ephemeral Environment deployment-53620

:cloud: https://app.uffizzi.com/github.com/Flagsmith/flagsmith/pull/4265

:page_facing_up: View Application Logs etc.

What is Uffizzi? Learn more!

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.59%. Comparing base (c2a33e6) to head (d9e3a45).

Files Patch % Lines
api/segments/models.py 30.00% 7 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4265 +/- ## ========================================== - Coverage 96.60% 96.59% -0.02% ========================================== Files 1195 1196 +1 Lines 39099 39114 +15 ========================================== + Hits 37773 37781 +8 - Misses 1326 1333 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.