search

Flagsmith / flagsmith

Open Source Feature Flagging and Remote Config Service. Host on-prem or use our hosted version at https://flagsmith.com/
https://flagsmith.com/
BSD 3-Clause "New" or "Revised" License
4.77k stars 365 forks source link

fix: ensure MANAGE_TAGS permission allows create tag #4678

Closed matthewelwell closed 11 hours ago

matthewelwell commented 1 day ago

Changes

Fixes an issue found in testing #4615 where it was not possible to create a tag when a user had the MANAGE_TAGS permission.

How did you test this code?

Added new tests to confirm both negative and positive cases.

vercel[bot] commented 1 day ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

3 Skipped Deployments | Name | Status | Preview | Comments | Updated (UTC) | | :--- | :----- | :------ | :------- | :------ | | **docs** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/docs/Hs7XUqWh6nVXU68a3L8hbiJVMRc4)) | | | Oct 1, 2024 2:36pm | | **flagsmith-frontend-preview** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-preview/FoHtmjJVvxdGgbHEys2DkFUPS9bH)) | | | Oct 1, 2024 2:36pm | | **flagsmith-frontend-staging** | ⬜️ Ignored ([Inspect](https://vercel.com/flagsmith/flagsmith-frontend-staging/5fKs6oTgMrE6PqbvjqCrkoAbVSe6)) | | | Oct 1, 2024 2:36pm |
github-actions[bot] commented 1 day ago

Docker builds report

Image Build Status Security report
ghcr.io/flagsmith/flagsmith-e2e:pr-4678 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-api-test:pr-4678 Finished :white_check_mark: Skipped
ghcr.io/flagsmith/flagsmith-api:pr-4678 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith:pr-4678 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-frontend:pr-4678 Finished :white_check_mark: Results :white_check_mark:
ghcr.io/flagsmith/flagsmith-private-cloud:pr-4678 Finished :white_check_mark: Results :white_check_mark:
github-actions[bot] commented 1 day ago

Uffizzi Preview deployment-56808 was deleted.

codecov[bot] commented 1 day ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.19%. Comparing base (59aa2f7) to head (99ce47b). Report is 7 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #4678 +/- ## ======================================= Coverage 97.19% 97.19% ======================================= Files 1166 1166 Lines 40436 40447 +11 ======================================= + Hits 39301 39312 +11 Misses 1135 1135 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.