search

FlamedDogo99 / EaglerMobile

A userscript that allows EaglerCraft to run on mobile browsers. As of June 15, 2023, the Eagler Mobile script is directly integrated with the main EaglerCraft website!
Apache License 2.0
15 stars 19 forks source link

Separate Mobile Controls From Other Features #6

Closed RealPlurr closed 3 months ago

RealPlurr commented 4 months ago

Hopefully will work I probably messed up with } in wrong place if so fix it. Anyways it muss work technically, I'll test it in a while and inform about results here

RealPlurr commented 4 months ago

Yeah Messed up leme update

RealPlurr commented 4 months ago

Now its ready to go, I tested and it works fine.

PlurrYT-Kolama commented 4 months ago

kinda out of date beacuse of issue i wont close it beacuse ill update it to new version after issue with keyboard will get fixed

FlamedDogo99 commented 4 months ago

Please provide some explanation for the change, as I’m leaning towards rejecting it for accessibility.

RealPlurr commented 4 months ago

Ok. So this just changes line where it checks for mobile. I just changed this line so it removes alerts and from if(! ismobile i deleted ! And now this if called if device is mobile. Then i opened { for rest of code so one like it was and second } moved go whole bottom. I understand still can be false positives on very very old devices or browsers but mainly it works on several browsers and devices (tested with my community)

RealPlurr commented 4 months ago

Aka mobile buttons will now appear only on mobile devices and wont appear on pc

colbster937 commented 4 months ago

but why would you be using this userscript on pc anyway?

PlurrYT-Kolama commented 4 months ago

i mean if u do public launcher like uh it will probably need some detection

colbster937 commented 4 months ago

I mean for my launcher https://webmc.xyz it just detects if your on mobile and redirects you to https://m.webmc.xyz so it kinda is useless

FlamedDogo99 commented 3 months ago

Apologies for the late reply. With gamepad support in the works and keyboard events fixed for Android users, it's looking like this will be useful for more than mobile. As more functionality is added, I'm planning on allowing dynamic enabling and disabling of the different sections. This means that this check will likely be removed all-together soon. Thanks for taking the time to submit a pull request.